From b36a6a74b0640e6bc4ac99f339315f31223cefef Mon Sep 17 00:00:00 2001
From: Bengt Brodersen <b.brodersen@xplosion.de>
Date: Thu, 10 Dec 2015 14:15:05 +0100
Subject: [PATCH] cleanup

---
 bookmarklet.js    | 55 ++++++++++++++++++++---------------------------
 card.css          |  6 +++---
 printPreview.html |  1 +
 3 files changed, 27 insertions(+), 35 deletions(-)

diff --git a/bookmarklet.js b/bookmarklet.js
index 55fcdf5..c5deccc 100644
--- a/bookmarklet.js
+++ b/bookmarklet.js
@@ -100,6 +100,7 @@
     jQuery("#hide-description-checkbox").attr('checked', settings.hideDescription );
     jQuery("#hide-assignee-checkbox").attr('checked', settings.hideAssignee );
     jQuery("#hide-due-date-checkbox").attr('checked', settings.hideDueDate );
+    jQuery("#hide-qr-code-checkbox").attr('checked', settings.hideQrCode );
 
     jQuery("#card-print-dialog-title").text("Card Printer " + global.version + " - Loading issues...");
     promises.push(renderCards(issueKeyList).then(function() {
@@ -161,6 +162,7 @@
     writeCookie("card_printer_hide_description", settings.hideDescription);
     writeCookie("card_printer_hide_assignee", settings.hideAssignee);
     writeCookie("card_printer_hide_due_date", settings.hideDueDate);
+    writeCookie("card_printer_hide_qr_code", settings.hideQrCode);
   }
 
   function loadSettings(){
@@ -173,6 +175,7 @@
     settings.hideDescription = parseBool(readCookie("card_printer_hide_description"), false);
     settings.hideAssignee = parseBool(readCookie("card_printer_hide_assignee"), false);
     settings.hideDueDate = parseBool(readCookie("card_printer_hide_due_date"), false);
+    settings.hideQrCode = parseBool(readCookie("card_printer_hide_qr_code"), false);
   }
 
   function print() {
@@ -266,26 +269,26 @@
         card.find(".issue-assignee").text(data.assignee[0].toUpperCase());
       }
     } else {
-      card.find(".issue-assignee").addClass("hidden");
+      card.find(".issue-assignee").remove();
     }
 
     //Due-Date
     if (data.dueDate) {
       card.find(".issue-due-date").text(data.dueDate);
     } else {
-      card.find(".issue-due-box").addClass("hidden");
+      card.find(".issue-due-box").remove();
     }
 
     //Attachment
     if (data.hasAttachment) {} else {
-      card.find('.issue-attachment').addClass('hidden');
+      card.find('.issue-attachment').remove();
     }
 
     //Story Points
     if (data.storyPoints) {
       card.find(".issue-estimate").text(data.storyPoints);
     } else {
-      card.find(".issue-estimate").addClass("hidden");
+      card.find(".issue-estimate").remove();
     }
 
     //Epic
@@ -293,7 +296,7 @@
       card.find(".issue-epic-id").text(data.superIssue.key);
       card.find(".issue-epic-name").text(data.superIssue.summary);
     } else {
-      card.find(".issue-epic-box").addClass("hidden");
+      card.find(".issue-epic-box").remove();
     }
 
     //QR-Code
@@ -309,34 +312,13 @@
     var printDocument = printWindow.document;
 
     // hide/show description
-    jQuery("#styleHideDescription", printDocument).remove();
-    if (settings.hideDescription) {
-      var style = document.createElement('style');
-      style.id = 'styleHideDescription';
-      style.type = 'text/css';
-      style.innerHTML = ".issue-description { display: none; }"
-      jQuery("head", printDocument).append(style);
-    }
-
+    jQuery(".issue-description", printDocument).toggle(!settings.hideDescription);
     // hide/show assignee
-    jQuery("#styleHideAssignee", printDocument).remove();
-    if (settings.hideAssignee) {
-      var style = document.createElement('style');
-      style.id = 'styleHideAssignee';
-      style.type = 'text/css';
-      style.innerHTML = ".issue-assignee { display: none; }"
-      jQuery("head", printDocument).append(style);
-    }
-
+    jQuery(".issue-assignee", printDocument).toggle(!settings.hideAssignee);
     // hide/show assignee
-    jQuery("#styleHideDueDate", printDocument).remove();
-    if (settings.hideDueDate) {
-      var style = document.createElement('style');
-      style.id = 'styleHideDueDate';
-      style.type = 'text/css';
-      style.innerHTML = ".issue-due-box { display: none; }"
-      jQuery("head", printDocument).append(style);
-    }
+    jQuery(".issue-due-box", printDocument).toggle(!settings.hideDueDate);
+    // hide/show cr code
+    jQuery(".issue-qr-code", printDocument).toggle(!settings.hideQrCode);
 
     // enable/disable single card page
     jQuery("#styleSingleCardPage", printDocument).remove();
@@ -344,7 +326,7 @@
       var style = document.createElement('style');
       style.id = 'styleSingleCardPage';
       style.type = 'text/css';
-      style.innerHTML = ".card { page-break-after: always; float: none; margin-bottom: 0.5cm}"
+      style.innerHTML = ".card { page-break-after: always; float: none;}"
       jQuery("head", printDocument).append(style);
     }
   }
@@ -491,6 +473,15 @@
       return true;
     });
 
+    // show QR Code
+
+    result.find("#hide-qr-code-checkbox").click(function() {
+      global.settings.hideQrCode = this.checked;
+      saveSettings();
+      redrawCards();
+      return true;
+    });
+
     // scale font
 
     result.find("#scaleRange").on("input", function() {
diff --git a/card.css b/card.css
index bf7295a..5139381 100644
--- a/card.css
+++ b/card.css
@@ -75,7 +75,7 @@ body {
   padding: 0.5rem;
   min-width: 14.5rem;
   min-height: 8.65rem;
-  overflow: visible;
+  overflow: hidden;
 }
 .card::after {
   overflow: visible;
@@ -83,8 +83,8 @@ body {
   top: -0.015rem;
   left: -0.015rem;
   content: "";
-  width: calc(100% - 0.015cm);
-  height: calc(100% - 0.015cm);
+  width: calc(100% - 0.03cm);
+  height: calc(100% - 0.03cm);
   border-color: LightGray;
   border-style: dashed;
   border-width: 0.03cm;
diff --git a/printPreview.html b/printPreview.html
index d5c2aeb..1b13073 100644
--- a/printPreview.html
+++ b/printPreview.html
@@ -27,6 +27,7 @@
         <div style="float: left; margin-right:10px"><input id="hide-description-checkbox" type="checkbox"/>Hide Description</div>
         <div style="float: left; margin-right:10px"><input id="hide-assignee-checkbox" type="checkbox"/>Hide Assignee</div>
         <div style="float: left; margin-right:10px"><input id="hide-due-date-checkbox" type="checkbox"/>Hide Due Date</div>
+        <div style="float: left; margin-right:10px"><input id="hide-qr-code-checkbox" type="checkbox"/>Hide QR Code</div>
 
         <input style="float: right;" id="card-print-dialog-print" type="button" class="aui-button aui-button-primary" value="Print" />
         <a style="float: right;" id="card-print-dialog-cancel" title="Cancel" class="cancel">Cancel</a>