* some test code cleanup

This commit is contained in:
Danyi Dávid 2018-01-15 23:07:21 +01:00
parent b79cea9fb2
commit 8cde36864d
4 changed files with 4 additions and 10 deletions

View File

@ -6,7 +6,6 @@ use App\Action\GetLatestCameraPicturesAction;
use App\Service\CameraPictureManagerService; use App\Service\CameraPictureManagerService;
use Interop\Http\ServerMiddleware\DelegateInterface; use Interop\Http\ServerMiddleware\DelegateInterface;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Psr\Http\Message\ServerRequestInterface; use Psr\Http\Message\ServerRequestInterface;
use Zend\Diactoros\Response\JsonResponse; use Zend\Diactoros\Response\JsonResponse;
@ -18,8 +17,6 @@ class GetLatestCameraPicturesActionTest extends TestCase
protected function setUp() protected function setUp()
{ {
$this->cameraPictureManager = $this->prophesize(CameraPictureManagerService::class); $this->cameraPictureManager = $this->prophesize(CameraPictureManagerService::class);
// $this->cameraPictureManager->getLatestCameraPictures()
// ->willReturn([]);
} }
public function testReturnsJsonResponse() public function testReturnsJsonResponse()

View File

@ -6,7 +6,6 @@ use App\Action\ShowCameraImageAction;
use App\Service\CameraPictureManagerService; use App\Service\CameraPictureManagerService;
use Interop\Http\ServerMiddleware\DelegateInterface; use Interop\Http\ServerMiddleware\DelegateInterface;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Psr\Http\Message\ServerRequestInterface; use Psr\Http\Message\ServerRequestInterface;
use Zend\Diactoros\Response\JsonResponse; use Zend\Diactoros\Response\JsonResponse;
@ -32,10 +31,8 @@ class ShowCameraImageActionTest extends TestCase
); );
$request = $this->prophesize(ServerRequestInterface::class); $request = $this->prophesize(ServerRequestInterface::class);
$request->getAttribute('camera') $request->getAttribute('camera')->willReturn(self::CAM_DIR);
->willReturn('cam1'); $request->getAttribute('image')->willReturn(self::IMG_FILE);
$request->getAttribute('image')
->willReturn('img1.png');
$response = $homePage->process( $response = $homePage->process(
$request->reveal(), $request->reveal(),